build and upload k8s resource files from helm as the base#96
Conversation
bcb700f to
191b3c7
Compare
191b3c7 to
ffd4b36
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 8 8
Lines 584 584
=======================================
Hits 543 543
Misses 29 29
Partials 12 12Continue to review full report at Codecov.
|
jaypipes
left a comment
There was a problem hiding this comment.
Only major request from me is to remove the change to the PSP default value (see inline for explanation). Otherwise, this is awesomeness.
19ed764 to
33e7361
Compare
| BUILD_DIR=$SCRIPTPATH/../build/k8s-resources/$VERSION | ||
| INDV_RESOURCES_DIR=$BUILD_DIR/indv-resources | ||
| TAR_RESOURCES_FILE=$BUILD_DIR/aws-node-termination-handler-k8s-resources.tar | ||
| AGG_RESOURCES_YAML=$BUILD_DIR/aws-node-termination-handler.yaml |
There was a problem hiding this comment.
I still think it would be a little more cogent to name the tarball individual-resources.tar and the aggregated YAML file all.yaml or all-resources.yaml. Thoughts?
There was a problem hiding this comment.
ah yes, I see what you mean. I overlooked the additional stutter in your first comment. I'll update
33e7361 to
2f048d1
Compare
Issue #, if available:
#93
Description of changes:
Script the generation of plain kubernetes resources yaml files to upload as assets to the github release. This change supports users who would rather not use helm to install aws-node-termination-handler.
I also set the default in helm for psp generation to true. afaik, generating the psp won't harm anything even if rbac is not enabled in the cluster, but correct me if I'm wrong.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.