Skip to content

build and upload k8s resource files from helm as the base#96

Merged
jaypipes merged 1 commit into
aws:masterfrom
bwagner5:k8s-resources
Feb 18, 2020
Merged

build and upload k8s resource files from helm as the base#96
jaypipes merged 1 commit into
aws:masterfrom
bwagner5:k8s-resources

Conversation

@bwagner5

@bwagner5 bwagner5 commented Feb 14, 2020

Copy link
Copy Markdown
Contributor

Issue #, if available:
#93

Description of changes:

  • Script the generation of plain kubernetes resources yaml files to upload as assets to the github release. This change supports users who would rather not use helm to install aws-node-termination-handler.

  • I also set the default in helm for psp generation to true. afaik, generating the psp won't harm anything even if rbac is not enabled in the cluster, but correct me if I'm wrong.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Comment thread Makefile Outdated
@codecov-io

codecov-io commented Feb 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files           8        8           
  Lines         584      584           
=======================================
  Hits          543      543           
  Misses         29       29           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216afec...2f048d1. Read the comment docs.

@jaypipes jaypipes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only major request from me is to remove the change to the PSP default value (see inline for explanation). Otherwise, this is awesomeness.

Comment thread config/helm/aws-node-termination-handler/values.yaml Outdated
Comment thread README.md
Comment thread scripts/generate-k8s-yaml Outdated
Comment thread scripts/generate-k8s-yaml
Comment thread README.md Outdated
Comment thread scripts/upload-resources-to-github Outdated
BUILD_DIR=$SCRIPTPATH/../build/k8s-resources/$VERSION
INDV_RESOURCES_DIR=$BUILD_DIR/indv-resources
TAR_RESOURCES_FILE=$BUILD_DIR/aws-node-termination-handler-k8s-resources.tar
AGG_RESOURCES_YAML=$BUILD_DIR/aws-node-termination-handler.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it would be a little more cogent to name the tarball individual-resources.tar and the aggregated YAML file all.yaml or all-resources.yaml. Thoughts?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I see what you mean. I overlooked the additional stutter in your first comment. I'll update

@jaypipes jaypipes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bueno :)

@jaypipes jaypipes merged commit 6680f16 into aws:master Feb 18, 2020
@bwagner5 bwagner5 deleted the k8s-resources branch July 15, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants