Skip to content

Conversation

@jdeamicis
Copy link
Contributor

@jdeamicis jdeamicis commented Jan 10, 2023

Description of changes

  • Add simple framework to patch Slurm source code before building.
  • Add patch to fix the scontrol update nodelist sorting bug.
  • Add git to as base package for all AMIs

Tests

References

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Filename pattern expansion is guaranteed to be sorted alphabetically:
https://www.gnu.org/software/bash/manual/bash.html#Filename-Expansion

Use nullglob bash option to handle case with no patches in patch folder.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
@jdeamicis jdeamicis force-pushed the wip/v3.4/apply_slurm_patch branch from 2856d13 to 62357b0 Compare January 10, 2023 15:48
Remove git from the base packages for CentOS and Debian (Ubuntu).

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
@jdeamicis jdeamicis merged commit a5cc72e into aws:release-3.4 Jan 10, 2023
@jdeamicis jdeamicis deleted the wip/v3.4/apply_slurm_patch branch January 10, 2023 17:29
himani2411 pushed a commit to himani2411/aws-parallelcluster-cookbook that referenced this pull request Aug 22, 2023
Add steps to apply patches to Slurm tarball

Filename pattern expansion is guaranteed to be sorted alphabetically:
https://www.gnu.org/software/bash/manual/bash.html#Filename-Expansion

Use nullglob bash option to handle case with no patches in patch folder.

Add Slurm patch for scontrol update nodelist sorting bug

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants