Add integration test for scontrol update nodelist sorting bug #4785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
Slurm 22.05 (up to 22.05.7) sorts the nodes in nodelist provided as nodename field to the `scontrol update` command. If `scontrol update nodename=nodelist nodeaddr=nodeaddrlist` is given, this causes a mismatch between the nodenames and the nodeaddrs because the order of nodeaddrlist is not changed to match the reordering of nodelist. The bug above will be fixed in Slurm 22.05.8 and later. The added test checks that the sorting of the nodelist does not happen. Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
jdeamicis
force-pushed
the
wip/v3.4/apply_slurm_patch
branch
from
41a0d83 to
c3b4c55
Compare
Codecov Report
@@ Coverage Diff @@
## release-3.4 #4785 +/- ##
============================================
Coverage 89.04% 89.04%
============================================
Files 163 163
Lines 14369 14369
============================================
Hits 12795 12795
Misses 1574 1574
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
| assert_that(slurm_commands.get_node_attribute(nodes_in_queue1[0], "NodeAddr")).is_equal_to(nodes_in_queue1[0]) | ||
| assert_that(slurm_commands.get_node_attribute(nodes_in_queue2[0], "NodeAddr")).is_equal_to(nodes_in_queue2[0]) | ||
|
|
||
| remote_command_executor.run_remote_command("sudo systemctl start supervisord") |
Contributor
There was a problem hiding this comment.
if this isn't needed I would remove this
Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
lukeseawalker
approved these changes
Jan 10, 2023
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster
that referenced
this pull request
Jan 10, 2023
Add integration test for scontrol update nodelist sorting bug Slurm 22.05 (up to 22.05.7) sorts the nodes in nodelist provided as nodename field to the `scontrol update` command. If `scontrol update nodename=nodelist nodeaddr=nodeaddrlist` is given, this causes a mismatch between the nodenames and the nodeaddrs because the order of nodeaddrlist is not changed to match the reordering of nodelist. The bug above will be fixed in Slurm 22.05.8 and later. Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
4 tasks
lukeseawalker
pushed a commit
that referenced
this pull request
Jan 11, 2023
Add integration test for scontrol update nodelist sorting bug Slurm 22.05 (up to 22.05.7) sorts the nodes in nodelist provided as nodename field to the `scontrol update` command. If `scontrol update nodename=nodelist nodeaddr=nodeaddrlist` is given, this causes a mismatch between the nodenames and the nodeaddrs because the order of nodeaddrlist is not changed to match the reordering of nodelist. The bug above will be fixed in Slurm 22.05.8 and later. Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
scontrol updatenodelist sorting bug (see Apply Slurm patch to fix scontrol update nodelist sorting aws-parallelcluster-cookbook#1638).References
scontrol updatenodelist sorting bug: Apply Slurm patch to fix scontrol update nodelist sorting aws-parallelcluster-cookbook#1638Checklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.