Process the config option DeploymentSettings/DefaultUserHome to change the default user's home directory #2620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreambeyondorange
force-pushed
the
relocate-home
branch
from
39a93c1 to
efc7960
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2620 +/- ##
========================================
Coverage 76.37% 76.37%
========================================
Files 22 22
Lines 2248 2248
========================================
Hits 1717 1717
Misses 531 531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dreambeyondorange
force-pushed
the
relocate-home
branch
3 times, most recently
from
9d10319 to
3a9912f
Compare
dreambeyondorange
changed the title
gmarciani
reviewed
Jan 23, 2024
cookbooks/aws-parallelcluster-environment/recipes/init/move_default_user.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-environment/recipes/init/move_default_user.rb
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-environment/recipes/init/move_default_user.rb
Outdated
Show resolved
Hide resolved
cookbooks/aws-parallelcluster-environment/recipes/init/move_default_user.rb
Show resolved
Hide resolved
dreambeyondorange
force-pushed
the
relocate-home
branch
6 times, most recently
from
b02dd6e to
d43b73c
Compare
gmarciani
reviewed
Jan 25, 2024
cookbooks/aws-parallelcluster-environment/kitchen.environment-config.yml
Show resolved
Hide resolved
gmarciani
reviewed
Feb 1, 2024
cookbooks/aws-parallelcluster-environment/recipes/init/config_default_user_home.rb
Outdated
Show resolved
Hide resolved
dreambeyondorange
changed the title
dreambeyondorange
changed the title
dreambeyondorange
force-pushed
the
relocate-home
branch
10 times, most recently
from
ec699c2 to
1c2cf37
Compare
dreambeyondorange
force-pushed
the
relocate-home
branch
4 times, most recently
from
3336f87 to
a36b49f
Compare
…e the cluster user out of /home when the default_user_home option is set to local Refactored the cookbook to use an attribute for the default user's home directory so that it can be changed when using the new config option. Also simplified the users attribute file since the exta OS specific files were not adding any value and duplicating code.
dreambeyondorange
force-pushed
the
relocate-home
branch
from
a36b49f to
e5e384d
Compare
himani2411
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is set to local
Refactored the cookbook to use an attribute for the default user's home directory so that it can be
changed when using the new config option. Also simplified the users attribute file since the exta OS
specific files were not adding any value and duplicating code.
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.