Skip to content

Conversation

@dreambeyondorange
Copy link
Contributor

@dreambeyondorange dreambeyondorange commented Jan 22, 2024

Add the config option DefaultUserHome under DeploymentSettings to change the default user's home directory

Move the cluster user out of /home and into /local/home when the DefaultUserHome option is set to local

Tests

  • Created clusters locally using both options to ensure the directory was placed correctly

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange requested review from a team as code owners January 22, 2024 17:02
@dreambeyondorange dreambeyondorange force-pushed the relocate-home branch 4 times, most recently from 20ba277 to daadc63 Compare January 22, 2024 17:35
@gmarciani
Copy link
Contributor

May you please describe the change and how you tested it?

@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b20d842) 90.24% compared to head (f4bea2f) 90.24%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6028   +/-   ##
========================================
  Coverage    90.24%   90.24%           
========================================
  Files          181      181           
  Lines        15887    15895    +8     
========================================
+ Hits         14337    14345    +8     
  Misses        1550     1550           
Flag Coverage Δ
unittests 90.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange force-pushed the relocate-home branch 3 times, most recently from aabe91e to acb8802 Compare January 24, 2024 21:41
@dreambeyondorange dreambeyondorange changed the title Add the config option under HeadNode to change the default user's hom… Add the config option DeploymentSettings/DefaultUserHome to change the default user's home directory Feb 5, 2024
@dreambeyondorange dreambeyondorange force-pushed the relocate-home branch 9 times, most recently from 6a4138e to bce828f Compare February 9, 2024 21:11
@dreambeyondorange dreambeyondorange force-pushed the relocate-home branch 3 times, most recently from 7612141 to 7f365ce Compare February 12, 2024 16:46
…ge the default user's home directory across the cluster

Move the cluster user out of `/home` and into `/local/home` when the `DefaultUserHome` option is set to local
@dreambeyondorange dreambeyondorange merged commit 6406784 into aws:develop Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants