Skip to content

Conversation

@gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Mar 1, 2024

Description of changes

  1. Add a syncronization point between head node and login nodes, so that login nodes wait for the head node to write the keys before attempting to import them. The lack of dependency is the source of sporadic bootstrap failures in login nodes.
  2. Make DFSM check able to handle missing change-set: when a change-set file is missing then for sure mount/unmount is not required.
  3. Clarify a comment describing the role of a syncronization file
  4. Add tests

Tests

  • Spec test
  • Kitchen: ./kitchen.ec2.sh environment-config test login-nodes-keys-configuration-alinux2
  • test_shared_home succeeded; it used to show login nodes bootstrap failures before this change.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gmarciani gmarciani requested review from a team as code owners March 1, 2024 17:49
@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (77832de) to head (dbc7af3).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.9    #2671   +/-   ##
============================================
  Coverage        76.48%   76.48%           
============================================
  Files               22       22           
  Lines             2220     2220           
============================================
  Hits              1698     1698           
  Misses             522      522           
Flag Coverage Δ
unittests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmarciani gmarciani changed the base branch from develop to release-3.9 March 1, 2024 17:53
@gmarciani gmarciani force-pushed the wip/mgiacomo/390/fix-shared-home-0301 branch from 71bf098 to 5f36c71 Compare March 1, 2024 17:56
himani2411
himani2411 previously approved these changes Mar 1, 2024
…onfig file.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…he lack of the changeset file.

In particular, we consider mount/unmount not required if the change-set file is missing.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…d 'are_mount_or_unmount_required'.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani force-pushed the wip/mgiacomo/390/fix-shared-home-0301 branch from 5f36c71 to 6122d06 Compare March 1, 2024 18:28
wait for the head node to write keys.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani force-pushed the wip/mgiacomo/390/fix-shared-home-0301 branch from 6122d06 to 23feaf0 Compare March 1, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants