-
Notifications
You must be signed in to change notification settings - Fork 109
Add sync point between head node and login nodes + make DFSM check able to handle missing change-set #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gmarciani
merged 5 commits into
aws:release-3.9
from
gmarciani:wip/mgiacomo/390/fix-shared-home-0301
Mar 2, 2024
Merged
Add sync point between head node and login nodes + make DFSM check able to handle missing change-set #2671
gmarciani
merged 5 commits into
aws:release-3.9
from
gmarciani:wip/mgiacomo/390/fix-shared-home-0301
Mar 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.9 #2671 +/- ##
============================================
Coverage 76.48% 76.48%
============================================
Files 22 22
Lines 2220 2220
============================================
Hits 1698 1698
Misses 522 522
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
71bf098 to
5f36c71
Compare
himani2411
reviewed
Mar 1, 2024
himani2411
previously approved these changes
Mar 1, 2024
…onfig file. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…he lack of the changeset file. In particular, we consider mount/unmount not required if the change-set file is missing. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…d 'are_mount_or_unmount_required'. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
5f36c71 to
6122d06
Compare
cookbooks/aws-parallelcluster-environment/spec/unit/recipes/login_nodes_keys_spec.rb
Outdated
Show resolved
Hide resolved
wait for the head node to write keys. Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
6122d06 to
23feaf0
Compare
dreambeyondorange
approved these changes
Mar 1, 2024
This was referenced Mar 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
test_shared_homesucceeded; it used to show login nodes bootstrap failures before this change.References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.