Skip to content

Conversation

@gmarciani
Copy link
Contributor

Description of changes

Cherry-picked from #2671

Tests

Tested as part of the original PR.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…onfig file.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…he lack of the changeset file.

In particular, we consider mount/unmount not required if the change-set file is missing.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
…d 'are_mount_or_unmount_required'.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
wait for the head node to write keys.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani requested review from a team as code owners March 1, 2024 19:08
@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (e75e22f) to head (43bdf19).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2672   +/-   ##
========================================
  Coverage    76.48%   76.48%           
========================================
  Files           22       22           
  Lines         2220     2220           
========================================
  Hits          1698     1698           
  Misses         522      522           
Flag Coverage Δ
unittests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants