Skip to content

[Nvidia] Remove 'no-cc-version-check' from installation of nvidia driver #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
Merged

[Nvidia] Remove 'no-cc-version-check' from installation of nvidia driver #2878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9df46f2
[Nvidia] Remove 'no-cc-version-check' from installation of nvidia dri…
gmarciani Feb 17, 2025
1e1cc96
Merge branch 'develop' into wip/mgiacomo/3130/nvidia-restore-cc-versi…
gmarciani Feb 18, 2025
b8c1afb
Merge branch 'develop' into wip/mgiacomo/3130/nvidia-restore-cc-versi…
gmarciani Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
- Upgrade ARM PL to version 24.10 (from 23.10).
- Remove generation of DSA keys for login nodes as DSA, which became unsupported in OpenSSH 9.7+.
- Set instance ID and instance type information in Slurm upon compute nodes launch.
- Install NVIDIA drivers without the option 'no-cc-version-check', which is now deprecated in the NVIDIA installer.

3.12.0
------
Expand Down
3 changes: 1 addition & 2 deletions ...oks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,13 @@
end

# Install driver
# TODO remove --no-cc-version-check when we can update ubuntu 22 images
bash 'nvidia.run advanced' do
user 'root'
group 'root'
cwd '/tmp'
code <<-NVIDIA
set -e
#{compiler_path} ./nvidia.run --silent --dkms --disable-nouveau --no-cc-version-check -m=#{nvidia_kernel_module}
#{compiler_path} ./nvidia.run --silent --dkms --disable-nouveau -m=#{nvidia_kernel_module}
rm -f /tmp/nvidia.run
NVIDIA
creates '/usr/bin/nvidia-smi'
Expand Down
6 changes: 3 additions & 3 deletions cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def self.setup(chef_run, nvidia_driver_version: nil)
cwd: '/tmp',
creates: '/usr/bin/nvidia-smi'
)
.with_code(%r{CC=/usr/bin/gcc10-gcc ./nvidia.run --silent --dkms --disable-nouveau --no-cc-version-check -m=#{kernel_module}})
.with_code(%r{CC=/usr/bin/gcc10-gcc ./nvidia.run --silent --dkms --disable-nouveau -m=#{kernel_module}})
.with_code(%r{rm -f /tmp/nvidia.run})
end
elsif platform == 'ubuntu' && version == '22.04'
Expand Down Expand Up @@ -272,7 +272,7 @@ def self.setup(chef_run, nvidia_driver_version: nil)
cwd: '/tmp',
creates: '/usr/bin/nvidia-smi'
)
.with_code(%r{#{compiler_path} ./nvidia.run --silent --dkms --disable-nouveau --no-cc-version-check -m=#{kernel_module}})
.with_code(%r{#{compiler_path} ./nvidia.run --silent --dkms --disable-nouveau -m=#{kernel_module}})
end
else
it "doesn't install gcc10" do
Expand All @@ -286,7 +286,7 @@ def self.setup(chef_run, nvidia_driver_version: nil)
cwd: '/tmp',
creates: '/usr/bin/nvidia-smi'
)
.with_code(%r{./nvidia.run --silent --dkms --disable-nouveau --no-cc-version-check -m=#{kernel_module}})
.with_code(%r{./nvidia.run --silent --dkms --disable-nouveau -m=#{kernel_module}})
.with_code(%r{rm -f /tmp/nvidia.run})
end
end
Expand Down
Loading