[Nvidia] Remove 'no-cc-version-check' from installation of nvidia driver #2878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2878 +/- ##
========================================
Coverage 76.63% 76.63%
========================================
Files 22 22
Lines 2243 2243
========================================
Hits 1719 1719
Misses 524 524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
force-pushed
the
wip/mgiacomo/3130/nvidia-restore-cc-version-check-0217-1
branch
from
cf6f105 to
9df46f2
Compare
hanwen-cluster
approved these changes
Feb 19, 2025
gmarciani
deleted the
wip/mgiacomo/3130/nvidia-restore-cc-version-check-0217-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove 'no-cc-version-check' from installation of nvidia driver
We remove it because:
1/ it is not supported anymore by the NVIDIA installer.
2/ it was an unsafe workaround introduced in 3.8.0 (#2404), which was supposed to be there only in the short term and in ended be there for long time.
3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel #2852.
Tests
AMI build succeeded on all supported OSes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.