Skip to content

Conversation

@tmscarla
Copy link
Contributor

@tmscarla tmscarla commented Apr 21, 2023

Description

How Has This Been Tested?

  • Manually tested on local environment
    • Dry-run both successful and unsuccessful: verified that flashbar message is dismissed
    • Create successful: verified that flashbar message is not automatically dismissed and selected region is changed before redirect
    • Create unsuccessful: verified that flashbar message is dismissed

Screenshot

Screenshot 2023-04-21 at 14 50 31

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmscarla tmscarla requested a review from mendaomn April 21, 2023 12:59
@mendaomn mendaomn marked this pull request as draft April 21, 2023 13:20
@tmscarla tmscarla force-pushed the tsscarla/clusters-crash branch from b952125 to b157926 Compare April 21, 2023 14:58
@tmscarla tmscarla marked this pull request as ready for review April 21, 2023 15:16
@tmscarla tmscarla merged commit ef3231c into main Apr 21, 2023
@tmscarla tmscarla deleted the tsscarla/clusters-crash branch April 21, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clusters list view crashes when creating cluster in a different region than the one selected

2 participants