Skip to content

Conversation

@tmscarla
Copy link
Contributor

@tmscarla tmscarla commented Feb 16, 2023

Description

Currently the workflow to reset the password of a Cognito user within PCUI is broken, since the reset code does not arrive to the specified email. The issue is rooted in the fact that users that belong to the PCUI Cognito user pool have the email_verified attribute set to False by default.

This PR aims at solving the aforementioned issue by setting email_verified to True in Cognito user pool both for admin user and new users.

Closes #35.

How Has This Been Tested?

  • User creation has been tested on local environment, with a Cognito user pool deployed in my personal account
  • Admin user has been tested by uploading parallelcluster-ui-cognito.yaml template on S3 in my personal account, and testing a full deployment of PCUI
  • Verified that for both users reset password link works and email is received

References

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tmscarla tmscarla requested a review from BarcoMasile February 16, 2023 08:53
@tmscarla tmscarla merged commit b5d09ab into main Feb 16, 2023
@tmscarla tmscarla deleted the tsscarla/cognito-email-verified branch February 16, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to reset user password for users created from PCUI

3 participants