[Test] Add infrastructure unit tests#475
Merged
gmarciani merged 2 commits intoMay 1, 2026
Merged
Conversation
…adar. In particular, we introduced two unit tests: * permissions boundary: when a permission boundary is specified by the user, that boundary is injected in every role deployed by the infrastructure. * APIG policy: when private deployment is used, the APIG can only be invoked from within the VPCE; otherwise it can be invoked from everywhere.
…rkflow used to validate PRs.
gmarciani
force-pushed
the
wip/mgiacomo/2026/infra-unit-tests-0501-1
branch
from
f6dadcc to
faa8e5a
Compare
hanwen-cluster
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add unit testing for CloudFormation templates based on cloud-radar https://github.com/DontShaveTheYak/cloud-radar.
In particular, we introduced two unit tests:
* permissions boundary: when a permission boundary is specified by the user, that boundary is injected in every role deployed by the infrastructure.
* APIG policy: when private deployment is used, the APIG can only be invoked from within the VPCE; otherwise it can be invoked from everywhere.
Also, added those unit tests to the GitHub Workflow used to validate PRs.
NOTE FOR REVIEWER
The code in
conftestis mostly a porting of an unreleased change incloud-radarto allow the use of ForEach expression in CFN template DontShaveTheYak/cloud-radar#646. That logic is going to be removed as soon as cloud-radar releases this feature. The only logic that will remain is the fixturetemplateHow Has This Been Tested?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.