Remove clearAll from LoadInitialState to fix cluster deep link not selecting the cluster #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when loading PCUI with a deep link pointing to a specific cluster (e.g.
/clusters/{:clusterName}), the cluster in the deep link does not get selected.Steps to reproduce:
This PR aims at solving this issue by extracting the
clearAllStateout of theLoadInitialStatefunction and call it directly in the region selection callback, since its purpose is to clear the state whenLoadInitialStateis called when changing the region.Closes #30.
How Has This Been Tested?
PR Quality Checklist
react-i18nextlibrary (useTranslation hook and/or Trans component), see an example herenpm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.