Adding the changelog #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-pcluste
referenced
this pull request
in hanwen-pcluste/aws-parallelcluster
Jul 22, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
referenced
this pull request
in hanwen-pcluste/aws-parallelcluster
Jul 22, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
referenced
this pull request
in hanwen-pcluste/aws-parallelcluster
Jul 23, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section 5. Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
referenced
this pull request
in hanwen-pcluste/aws-parallelcluster
Jul 23, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section 5. Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
referenced
this pull request
in hanwen-pcluste/aws-parallelcluster
Jul 24, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section 5. Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
pushed a commit
that referenced
this pull request
Jul 26, 2021
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section 5. Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments Signed-off-by: Hanwen <hanwenli@amazon.com>
lukeseawalker
pushed a commit
that referenced
this pull request
Oct 19, 2022
1. Add a method `get_chosen_placement_group_setting_for_compute_resource` in `_CommonQueue` to handle logic that the Placement Group on compute resource level overrides queue level.. 2. Simplify `get_placement_group_settings_for_compute_resource` to use the new method in #1. 3. Simplify `get_managed_placement_group_keys` to use the method in #2 4. Remove `is_enabled_and_unassigned` because it is no longer used in #3 Signed-off-by: Hanwen <hanwenli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.