Restore default values in cfn template for ComputeInstanceType #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2284 +/- ##
========================================
Coverage 62.12% 62.12%
========================================
Files 40 40
Lines 6149 6149
========================================
Hits 3820 3820
Misses 2329 2329 Continue to review full report at Codecov.
|
enrico-usai
added
the
skip-changelog-update
enrico-usai
reviewed
Dec 3, 2020
| "MasterInstanceType": { | ||
| "Description": "Head node EC2 instance type", | ||
| "Type": "String", | ||
| "Default": "t2.micro", |
Contributor
There was a problem hiding this comment.
let's remove the default for the head node.
| "ComputeInstanceType": { | ||
| "Description": "ComputeFleet EC2 instance type", | ||
| "Type": "String", | ||
| "Default": "t2.micro", |
Contributor
There was a problem hiding this comment.
We can improve the description by highlighting the fact that this parameter is useless for Slurm but needed as CFN param.
We can use NONE instead of t2.micro to avoid hiding other errors. In this way we'll be sure that a value is always passed.
Compute instance type parameter is not rendered if scheduler is Slurm. This caused the error `Parameters: [ComputeInstanceType] must have values` in CloudFormation because a value was still expected. With this commit we set "NONE" as default to prevent this value being silently used as if set by the user. Signed-off-by: ddeidda <ddeidda@amazon.com>
ddeidda
force-pushed
the
fix_compute_instance_type_default
branch
from
c5434e1 to
fda018e
Compare
ddeidda
changed the title
enrico-usai
approved these changes
Dec 3, 2020
chenwany
pushed a commit
to chenwany/aws-parallelcluster
that referenced
this pull request
Dec 4, 2020
) Compute instance type parameter is not rendered if scheduler is Slurm. This caused the error `Parameters: [ComputeInstanceType] must have values` in CloudFormation because a value was still expected. With this commit we set "NONE" as default to prevent this value being silently used as if set by the user. Signed-off-by: ddeidda <ddeidda@amazon.com>
chenwany
pushed a commit
to chenwany/aws-parallelcluster
that referenced
this pull request
Dec 4, 2020
) Compute instance type parameter is not rendered if scheduler is Slurm. This caused the error `Parameters: [ComputeInstanceType] must have values` in CloudFormation because a value was still expected. With this commit we set "NONE" as default to prevent this value being silently used as if set by the user. Signed-off-by: ddeidda <ddeidda@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute instance type parameter is not rendered if scheduler is Slurm. This caused the error
Parameters: [ComputeInstanceType] must have valuesin CloudFormation because a value was still expected.With this commit we set "NONE" as default to prevent this value being silently used as if set by the user.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.