Skip to content

Restore default values in cfn template for ComputeInstanceType #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Restore default values in cfn template for ComputeInstanceType #2284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/tests/pcluster/config/test_source_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ def test_defaults_consistency():
# metadata is generated dynamically based on user's configuration.
ignored_params += ["ClusterConfigMetadata"]

# ComputeInstanceType parameter is expected to differ from the default value in the CFN template because
# it is dynamically generated based on the AWS region
ignored_params += ["ComputeInstanceType"]

cfn_params = [section_cfn_params.value for section_cfn_params in DefaultCfnParams]
default_cfn_values = utils.merge_dicts(*cfn_params)

Expand Down
1 change: 1 addition & 0 deletions cloudformation/aws-parallelcluster.cfn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"ComputeInstanceType": {
"Description": "ComputeFleet EC2 instance type",
"Type": "String",
"Default": "NONE",
"ConstraintDescription": "Must be a valid EC2 instance type, with support for HVM."
},
"MinSize": {
Expand Down