Skip to content

Conversation

@EddyMM
Copy link
Contributor

@EddyMM EddyMM commented Aug 23, 2023

Description of changes

  • One of the test assertions (_test_mpi_job_termination) checks if cancellation of an MPI process does not leave any stray processes
  • The MPI job completes before the test can cancel it on Ubuntu2204 (but the test runs successfully with more granular intervals)
  • The timing issue is non-existent in alinux2
  • These changes switch the test to running on alinux2 and follow up with an investigation on why the timing differs on Ubuntu2204 (and possibly improve this test to be less influenced by timing issues)

Tests

  • Ran the test (test_slurm::test_slurm)

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Ubuntu2204 requires different retry intervals in the test
@EddyMM EddyMM added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Aug 23, 2023
@EddyMM EddyMM marked this pull request as ready for review August 23, 2023 14:29
@EddyMM EddyMM requested review from a team as code owners August 23, 2023 14:29
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #5666 (3c69020) into release-3.7 (d7c44f5) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-3.7    #5666   +/-   ##
============================================
  Coverage        89.89%   89.89%           
============================================
  Files              179      179           
  Lines            15366    15366           
============================================
  Hits             13813    13813           
  Misses            1553     1553           
Flag Coverage Δ
unittests 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@EddyMM EddyMM closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant