Skip to content

Conversation

@NSsirena
Copy link
Contributor

Description of changes

While testing slurm we also test mpi job submission. The wait time to check the mpi job started was of
comparable size with the time requested to complete the job itself. This lead to flacky results.
By reducing this wait time the chances of failures should be greatly reduced.

  • wait-time to check that mpi-job is running reduced from 30s to 10s

Tests

  • Manually launched the test with Login Nodes and Ubuntu2204

References

N/A

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@NSsirena NSsirena added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Aug 18, 2023
@NSsirena NSsirena requested review from a team as code owners August 18, 2023 15:36
@NSsirena NSsirena enabled auto-merge (rebase) August 18, 2023 15:39
While testing slurm we also test mpi job submission.
The wait time to check the mpi job started was of
comparable size with the time requested to complete
the job itself. This lead to flacky results.
By reducing this wait time the chances of failures
should be greatly reduced.

Signed-off-by: Nicola Sirena <nssirena@amazon.com>
@NSsirena NSsirena force-pushed the rel37/test/fix-mpi-check-wait-time branch from 7ba7c28 to 005336c Compare August 18, 2023 15:40
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #5654 (7ba7c28) into release-3.7 (6490d2b) will not change coverage.
Report is 1 commits behind head on release-3.7.
The diff coverage is n/a.

❗ Current head 7ba7c28 differs from pull request most recent head 005336c. Consider uploading reports for the commit 005336c to get more accurate results

@@             Coverage Diff              @@
##           release-3.7    #5654   +/-   ##
============================================
  Coverage        89.89%   89.89%           
============================================
  Files              179      179           
  Lines            15366    15366           
============================================
  Hits             13813    13813           
  Misses            1553     1553           
Flag Coverage Δ
unittests 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants