Skip to content

Conversation

@EddyMM
Copy link
Contributor

@EddyMM EddyMM commented Aug 28, 2023

Description of changes

  • One of the test assertions (_test_mpi_job_termination) checks if cancellation of an MPI process does not leave any stray processes
  • The MPI job executed is an All-to-All MPI job. Timing when the job is running in order to cancel it is hard to predict.
  • These code changes use a simple sleep process instead with a deterministic runtime (5 mins). This way the test's check intervals have a higher guarantee of catching the MPI process while it's running.
  • The test also separates the clean up step (removing the shared file) from the retry steps

Tests

  • Ran the test (test_slurm::test_slurm) with Ubuntu2204

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…special timing conditions. (aws#5665)

Signed-off-by: Eddy Mwiti <eddmwiti@amazon.com>
@EddyMM EddyMM added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #5671 (ca3a508) into develop (3056029) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5671   +/-   ##
========================================
  Coverage    89.89%   89.89%           
========================================
  Files          179      179           
  Lines        15369    15369           
========================================
  Hits         13816    13816           
  Misses        1553     1553           
Flag Coverage Δ
unittests 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@EddyMM EddyMM marked this pull request as ready for review August 28, 2023 10:24
@EddyMM EddyMM requested review from a team as code owners August 28, 2023 10:24
@EddyMM EddyMM merged commit 089e291 into aws:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants