[Develop] Support for RHEL9 and Rocky9 #6018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-pcluste
force-pushed
the
develop
branch
from
b5b3c41 to
668c49e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6018 +/- ##
========================================
Coverage 90.21% 90.21%
========================================
Files 181 181
Lines 15827 15827
========================================
Hits 14278 14278
Misses 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hanwen-pcluste
force-pushed
the
develop
branch
3 times, most recently
from
7487e77 to
31158e1
Compare
hanwen-pcluste
changed the title
hanwen-pcluste
force-pushed
the
develop
branch
8 times, most recently
from
8517184 to
2d91425
Compare
Comment on lines
359
to
366
| log_file_owner_result = self.remote_command_executor.run_remote_command( | ||
| f"stat -c '%U' {log_path}", raise_on_error=False | ||
| ) | ||
| if log_file_owner_result.failed: | ||
| # If failed, it means the `log_path` does not contain files/directories. Use root as the default owner. | ||
| log_file_owner = "root" | ||
| else: | ||
| log_file_owner = log_file_owner_result.stdout.strip() |
Contributor
There was a problem hiding this comment.
Looks like this is repeated, perhaps this should defined as a function? a referenced here and above?
hanwen-pcluste
force-pushed
the
develop
branch
from
2d91425 to
50ca090
Compare
hanwen-pcluste
force-pushed
the
develop
branch
from
50ca090 to
87de6f6
Compare
gmarciani
reviewed
Jan 29, 2024
...tegration-tests/tests/update/test_update/test_dynamic_file_systems_update/storage-stack.yaml
Outdated
Show resolved
Hide resolved
hanwen-pcluste
force-pushed
the
develop
branch
2 times, most recently
from
66fad31 to
bf971b3
Compare
gmarciani
previously approved these changes
Feb 8, 2024
hanwen-pcluste
force-pushed
the
develop
branch
from
bf971b3 to
ec42261
Compare
hanwen-pcluste
changed the title
gmarciani
previously approved these changes
Feb 14, 2024
Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
test_multiple_fsx covers the checks in test_fsx_lustre Signed-off-by: Hanwen <hanwenli@amazon.com>
…pdate While testing RHEL9, we found t2.micro does not have enough memory for RHEL9 Signed-off-by: Hanwen <hanwenli@amazon.com>
FYI: the version of Lustre file systems created by pcluster CLI has already been upgraded to 2.12. We forgot to update integration tests code. Signed-off-by: Hanwen <hanwenli@amazon.com>
In many of the operating systems ParallelCluster supported, `root` user could bypass any files permissions. However, with RHEL9 and Rocky9, `root` user could not bypass files permissions by default. Therefore, this commit improves integration tests to operate on files with the owner users of the files Signed-off-by: Hanwen <hanwenli@amazon.com>
Signed-off-by: Hanwen <hanwenli@amazon.com>
The commands prior to this PR do not work with RHEL9. Therefore, we change the logic to use the command from the verified guide. I discussed the change with Giordano. We didn't have any concern. Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
develop
branch
from
ec42261 to
7bfddc2
Compare
gmarciani
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.