Skip to content

Conversation

@hanwen-pcluste
Copy link
Contributor

@hanwen-pcluste hanwen-pcluste commented Feb 16, 2024

This PR fixes minor bugs from #6018

  1. Add Rocky9 and RHEL9 to the kernel pinning logic. This was missed because the kernel pinning logic is new.
  2. Only test one NOT_RELEASED_OSES to keep the number of tests from increasing

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

1. Add Rocky9 and RHEL9 to the kernel pinning logic. This was missed because the kernel pinning logic is new.
2. Only test one NOT_RELEASED_OSES to keep the number of tests from increasing

Signed-off-by: Hanwen <hanwenli@amazon.com>
@hanwen-pcluste hanwen-pcluste requested review from a team as code owners February 16, 2024 16:38
@hanwen-pcluste hanwen-pcluste added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Feb 16, 2024
@codecov
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa66103) 90.21% compared to head (9ea1de8) 90.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6103   +/-   ##
========================================
  Coverage    90.21%   90.21%           
========================================
  Files          181      181           
  Lines        15837    15837           
========================================
  Hits         14287    14287           
  Misses        1550     1550           
Flag Coverage Δ
unittests 90.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanwen-pcluste hanwen-pcluste merged commit cb03709 into aws:develop Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants