Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Jan 2, 2025

Description of changes

  • Using cfn pseudo function ${AWS::URLSuffix} for getting URL domain

Keeping some hardcoded for EC2 SP's based on #3157

Tests

  • Manually Deployed the Templates

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jan 2, 2025
@himani2411 himani2411 requested review from a team as code owners January 2, 2025 16:09
@himani2411 himani2411 force-pushed the dev-tests branch 2 times, most recently from 087e3f9 to 746da5e Compare January 2, 2025 16:49
@himani2411 himani2411 merged commit 28330be into aws:develop Jan 3, 2025
24 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster that referenced this pull request Feb 26, 2025
Co-authored-by: Himani Anil Deshpande <himanidp@amazon.com>
himani2411 pushed a commit to himani2411/aws-parallelcluster that referenced this pull request Aug 18, 2025
himani2411 pushed a commit to himani2411/aws-parallelcluster that referenced this pull request Aug 25, 2025
himani2411 added a commit that referenced this pull request Aug 25, 2025
This reverts commit 28330be.

Co-authored-by: Himani Anil Deshpande <himanidp@amazon.com>
himani2411 pushed a commit to himani2411/aws-parallelcluster that referenced this pull request Oct 8, 2025
himani2411 pushed a commit to himani2411/aws-parallelcluster that referenced this pull request Oct 8, 2025
himani2411 added a commit that referenced this pull request Oct 8, 2025
This reverts commit 28330be.

Co-authored-by: Himani Anil Deshpande <himanidp@amazon.com>
himani2411 added a commit that referenced this pull request Oct 8, 2025
This reverts commit 28330be.

Co-authored-by: Himani Anil Deshpande <himanidp@amazon.com>
hanwen-cluster pushed a commit that referenced this pull request Nov 19, 2025
This reverts commit 28330be.

Co-authored-by: Himani Anil Deshpande <himanidp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants