Skip to content

Conversation

@himani2411
Copy link
Contributor

Description of changes

This reverts commit 28330be.

Tests

  • test_iam_roles and test_ad_integration in isolated regions passed with this change

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners August 25, 2025 16:10
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Aug 25, 2025
@himani2411 himani2411 force-pushed the release-3.13.2-aug18 branch from 55c9b6a to 7234c12 Compare August 25, 2025 16:11
Effect: Allow
Principal:
Service: !Sub ec2.${AWS::URLSuffix}
Service: ec2.amazonaws.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not applying the same approach we did for the other template?

Service: !If [ GovCloud, 'ec2.amazonaws-us-gov.com', !If [ China, 'ec2.amazonaws.cn', 'ec2.amazonaws.com']]

Copy link
Contributor Author

@himani2411 himani2411 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was something that I reverted so i prefer to revert to the original value that was existing instead of changing it now and re-testing it again in isolated regions.

I have already created a backlog task for deep diving on why we should keep the SP at all especially in isolated regions.

@himani2411 himani2411 merged commit 6989da4 into aws:release-3.13 Aug 25, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants