Block Tags updates on cluster update in ADC regions#7371
Merged
hanwen-cluster merged 2 commits intoMay 4, 2026
Conversation
hanwen-cluster
force-pushed
the
integ-tests-3.15.0
branch
from
9069799 to
ff60ed2
Compare
In us-iso*, us-isob* regions, CloudFormation has a behavior where an UpdateStack call that includes both a Tags change and a resource whose change is only in Metadata does not update that resource. This breaks the head node update flow: cfn-hup on the head node polls DescribeStackResource for Metadata changes on HeadNodeLaunchTemplate, never sees them when tags are updated in the same call, and the HeadNodeWaitCondition times out after 30 minutes. Until the CloudFormation behavior is addressed, block tag updates at the validation layer in ADC regions so the failure mode surfaces immediately. Commercial, GovCloud, and China regions are unaffected. Policy changes: - Add UpdatePolicy.SUPPORTED_UNLESS_ADC, equivalent to SUPPORTED outside ADC and UNSUPPORTED inside ADC. - Cover the new policy with parametrized unit tests across commercial, GovCloud, China, us-iso, us-isob, and empty region values.
hanwen-cluster
force-pushed
the
integ-tests-3.15.0
branch
from
ff60ed2 to
ab6146b
Compare
himani2411
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
test_tag_propagationhas passed in commercialtest_tag_propagationwill be run in ADC after the PR is mergedChecklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.