Skip to content

[CLI] Add CreateFleet instance info retrieval timeout configurable via DevSettings#7425

Open
hehe7318 wants to merge 2 commits into
aws:developfrom
hehe7318:wip/replace-privateip-matching-with-instanceid-cli
Open

[CLI] Add CreateFleet instance info retrieval timeout configurable via DevSettings#7425
hehe7318 wants to merge 2 commits into
aws:developfrom
hehe7318:wip/replace-privateip-matching-with-instanceid-cli

Conversation

@hehe7318
Copy link
Copy Markdown
Contributor

@hehe7318 hehe7318 commented Jun 5, 2026

Description of changes

Exposes the CreateFleet post-launch DescribeInstances retry timeout as a devsetting under DevSettings/Timeouts/ComputeInstanceInfoTimeout (default 90s).

When a compute resource uses CreateFleet (flexible instance types), the node package retries DescribeInstances after launch to tolerate EC2 API eventual consistency. This change lets that timeout be tuned from the cluster config:

DevSettings:
  Timeouts:
    ComputeInstanceInfoTimeout: 90  # seconds

Tests

  • Unit tests passed

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

hehe7318 added 2 commits June 5, 2026 15:01
… schema

Expose the CreateFleet post-launch DescribeInstances retry timeout (consumed by
the node package to tolerate EC2 API eventual consistency) as a dev setting under
DevSettings/Timeouts/ComputeInstanceInfoTimeout, defaulting to 90s.
@hehe7318 hehe7318 requested review from a team as code owners June 5, 2026 19:12
@hehe7318 hehe7318 added the 3.x label Jun 5, 2026
@hehe7318 hehe7318 changed the title Add CreateFleet instance info retrieval timeout configurable via DevSettings [CLI] Add CreateFleet instance info retrieval timeout configurable via DevSettings Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant