sam deploy improperly handles whitespace in tags

[zsabin]

Description

sam deploy fails to correctly handle whitespace in tag keys and values when passed using the --tags flag. AWS Cloudformation docs specify that whitespace is valid for both keys and values: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-resource-tags.html.

Steps to reproduce

sam deploy
--debug
--profile <>
--template-file <>
--capabilities CAPABILITY_IAM CAPABILITY_NAMED_IAM
--parameter-overrides <>
--stack-name <>
--tags "key name=foo bar"

Observed result

The command above will tag resources as name=foo

Expected result

Should tag resources as key name=foo bar

The same tags specified using the aws cloudformation deploy command will produce the expected result.

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)

1. OS: macOS
2. sam --version:
   SAM CLI, version 0.47.0

[justengland]

I also so the same issue with a dash

[sriram-mv]

#1968 this should have fixed this, closing this issue, re-open if you are still seeing this.

[ceberz]

I believe I'm seeing this behavior again with SAM version 1.52.

From my Makefile:

sam deploy \
  --template-file ./FOO.yml \
  --region us-west-2 \
  --stack-name FOO \
  --s3-prefix FOO \
  --s3-bucket FOO \
  --no-confirm-changeset \
  --no-fail-on-empty-changeset \
  --parameter-overrides \
  	Foo=bar \
    	Baz="bot" \
  --capabilities CAPABILITY_IAM CAPABILITY_NAMED_IAM \
  --tags \
    	"some:tag=foo-and-then-bar" \
    	"some:other:tag=foo and then bar"

When the stack is created, the some:tag tag has the correct value of foo-and-then-bar, but some:other:tag ends up with only the value foo.

This seems to happen regardless of whether the values are passed with quotes around the entire "key=value" or simply around "value".

  --tags \
    	"some:tag=foo-and-then-bar" \
    	"some:other:tag=foo and then bar"

...or:

  --tags \
    	some:tag="foo-and-then-bar" \
    	some:other:tag="foo and then bar"