fix(tests): accept '/' in durable execution ARN regex#9038
Merged
bnusunny merged 1 commit intoMay 21, 2026
Conversation
DurableIntegBase.assert_invoke_output parsed the ARN line of sam local invoke output with [a-f0-9-]+, which truncates at the first '/'. After aws-durable-execution-sdk-python-testing#216 the emulator returns <uuid>/<invocation-id>, so subsequent sam local execution history|stop|get calls in the same test received only the leading UUID and 404'd, failing every test_local_invoke_durable_function_* test plus test_execution_stop_already_completed with AssertionError: 1 != 0. Switching to \S+ captures the full ARN as printed and stays backwards-compatible with the old UUID-only form. Fixes aws#9037
vicheey
approved these changes
May 21, 2026
bnusunny
approved these changes
May 21, 2026
bchampp
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Fixes #9037
Description of changes
DurableIntegBase.assert_invoke_outputparsed the ARN line ofsam local invokeoutput with[a-f0-9-]+, which truncates at the first/.After aws-durable-execution-sdk-python-testing#216 the
emulator returns
<uuid>/<invocation-id>, so subsequentsam local execution history|stop|getcalls in the same test received only the leading UUIDand 404'd.
Switching to
\S+captures the full ARN as printed and remainsbackwards-compatible with the old UUID-only form.
Description of how you validated changes
assert_invoke_outputagainst the exact stdout captured in thefailing CI run; the patched regex extracts the full
<uuid>/<invocation-id>ARN. Old UUID-only stdout still extractscleanly.
make pr(init, schema, black-check, lint, test-all) — all greenlocally on Python 3.11.11 (9241 passed, 25 skipped, coverage 94.17%).
Full integration suite runs in CI on this PR.
Checklist
make prpassesmake update-reproducible-reqsif dependencies were changed (n/a)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.