docs(cfn-lang-ext): correct language-extensions precedence order#9042
Merged
Conversation
The activation precedence was documented as CLI > env var > samconfig.toml, but the actual behavior is CLI > samconfig.toml > env var. samconfig values are loaded into Click's default_map by configuration_callback, so by the time resolve_language_extensions_enabled runs, flag_value is already non-None and the env var is never consulted. Reorder the methods to match runtime behavior, drop the misleading word "equivalent", and add brief notes explaining why samconfig outranks the env var and when the env var is actually read.
roger-zhangg
approved these changes
May 21, 2026
vicheey
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
samconfig.tomlis loaded into Click'sdefault_mapbyconfiguration_callback(samcli/cli/cli_config_file.py:245), so by the timeresolve_language_extensions_enabledruns (samcli/lib/cfn_language_extensions/sam_integration.py:67-69),flag_valueis non-Noneand the env var is never consulted.Test plan
docs/cfn-language-extensions.mdand confirm the section is readable and the order is CLI flag → samconfig.toml → env var.language_extensions = trueinsamconfig.tomlandSAM_CLI_ENABLE_LANGUAGE_EXTENSIONS=0in the env — samconfig should win (LE on).