fix: follow redirects and add fallback for zlib download in pyinstaller build#9104
Merged
Conversation
… build The zlib.net URL now returns a redirect, causing curl to save a 185-byte redirect page instead of the tarball. This breaks tar extraction and causes the Linux pyinstaller build to fail. Add -L flag to follow redirects (matching the OpenSSL curl call) and add GitHub releases as a fallback mirror.
![aws-sam-tooling-bot[bot]](https://avatars.githubusercontent.com/b/1290?s=60&v=4){kind=small}
valerena
approved these changes
Jun 30, 2026
bnusunny
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Lflag to thecurlcommand for zlib download so redirects are followed (matching the existing OpenSSL curl call)github.com/madler/zlib) as a fallback mirror if zlib.net is unavailabletar xvftotar xzfto match the gzip format explicitlyRoot Cause
The
build-pyinstaller-linuxjob is failing becausehttps://www.zlib.net/zlib-1.3.2.tar.gznow returns an HTTP redirect. Without-L,curlsaves the 185-byte redirect page instead of the ~1.5 MB tarball, causingtarto fail with "not in gzip format". This cascades into the build artifact not being produced.Test plan
-Lflag locallytar xzfbuild-pyinstaller-linuxjob should pass on this PR