OverrideOptionsOnConnectionHandle must provide HttpRequest as callback data

[rosen-tomov]

Describe the feature

Adding custom SetHttpClientFactory and custom CurlHttpClient if great but there is no link between client and served request in function OverrideOptionsOnConnectionHandle.

Use Case

Implementing simultaneous and dynamic SSL checking and verification via SSL_CTX_set_verify (check for some connections, discard for other connections, etc.) with CURLOPT_SSL_CTX_FUNCTION is not possible because HttpClientFactory is static and there is no way to understand which option to use in OverrideOptionsOnConnectionHandle.

Proposed Solution

Declare OverrideOptionsOnConnectionHandle with additional parameter HttpRequest* and when invoked in CurlHttpClient::MakeRequest pass "request.get()" along with curl connection handler.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

[jmklix]

Thanks for taking the time to create this feature request. This is something that we might want to add in the future, but it is not a priority right now. If you are interested in having this additional parameter added please 👍 the original comment so we can gauge interest.

[Owsleys]

👍