Conversation
| } | ||
|
|
||
| static void TagTestBucket(const Aws::String& bucketName, const std::shared_ptr<S3CrtClient>& client) { | ||
| PutBucketTaggingRequest taggingRequest; |
Contributor
There was a problem hiding this comment.
please add
ASSERT_TRUE(!bucketName.empty());
ASSERT_TRUE(client);
just in case...
| #include <aws/s3/model/GetBucketLocationRequest.h> | ||
| #include <aws/s3/model/SelectObjectContentRequest.h> | ||
| #include <aws/s3/model/WriteGetObjectResponseRequest.h> | ||
| #include "aws/s3/model/PutBucketTaggingRequest.h" |
Contributor
There was a problem hiding this comment.
please follow the style of the file.
Collaborator
Author
There was a problem hiding this comment.
whoops, that is clion doing that
sbiscigl
force-pushed
the
integration-test-tagging
branch
from
feb437b to
abdb48c
Compare
SergeyRyabinin
approved these changes
Jul 12, 2022
sbiscigl
force-pushed
the
integration-test-tagging
branch
from
abdb48c to
5d8dbe5
Compare
sbiscigl
force-pushed
the
integration-test-tagging
branch
from
5d8dbe5 to
71876f6
Compare
jmklix
pushed a commit
that referenced
this pull request
Oct 12, 2022
jmklix
pushed a commit
that referenced
this pull request
Oct 12, 2022
jmklix
pushed a commit
that referenced
this pull request
Aug 11, 2023
amit-schreiber-firebolt
pushed a commit
to firebolt-analytics/aws-sdk-cpp
that referenced
this pull request
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds tags to our S3 integration test resources for ease of cleaning them up.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.