check if md5 body is null #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (checksumAlgorithmName == "md5") | ||
| { | ||
| httpRequest->SetHeaderValue(Http::CONTENT_MD5_HEADER, HashingUtils::Base64Encode(HashingUtils::CalculateMD5(*(request.GetBody())))); | ||
| if (request.GetBody()) |
Contributor
There was a problem hiding this comment.
hi,
first of all, could you please also fix this nullptr deference issue in this file for other hash algorithms?
secondly, did you check how it is going to work by actually calling s3?
I would try setting md5("") (md5 of nothing) value if user tries to set an empty body.
SergeyRyabinin
approved these changes
Aug 5, 2022
sdavtaker
approved these changes
Aug 8, 2022
jmklix
added a commit
that referenced
this pull request
Oct 12, 2022
Fix nullptr de-reference when body is null.
jmklix
added a commit
that referenced
this pull request
Oct 12, 2022
Fix nullptr de-reference when body is null.
jmklix
added a commit
that referenced
this pull request
Aug 11, 2023
Fix nullptr de-reference when body is null.
amit-schreiber-firebolt
pushed a commit
to firebolt-analytics/aws-sdk-cpp
that referenced
this pull request
May 8, 2025
Fix nullptr de-reference when body is null.
amit-schreiber-firebolt
pushed a commit
to firebolt-analytics/aws-sdk-cpp
that referenced
this pull request
May 8, 2025
This reverts commit 65a54f1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1973
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.