Skip to content

Empty credentials#2177

Merged
jmklix merged 3 commits intomainfrom
empty_credentials
Nov 8, 2022
Merged

Empty credentials#2177
jmklix merged 3 commits intomainfrom
empty_credentials

Conversation

@jmklix
Copy link
Copy Markdown
Member

@jmklix jmklix commented Nov 5, 2022

Issue #, if available:

Description of changes:
Add more checks when refreshing credentials

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmklix jmklix merged commit bd29bea into main Nov 8, 2022
@jmklix jmklix deleted the empty_credentials branch November 8, 2022 18:36
jmklix added a commit that referenced this pull request Aug 11, 2023
* check if AWScredentials IsEmpty

* Add expires soon check

* get correct AWScredentials
amit-schreiber-firebolt pushed a commit to firebolt-analytics/aws-sdk-cpp that referenced this pull request May 8, 2025
* check if AWScredentials IsEmpty

* Add expires soon check

* get correct AWScredentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants