Conversation
SergeyRyabinin
approved these changes
Nov 7, 2022
sdavtaker
approved these changes
Nov 7, 2022
11 tasks
jmklix
pushed a commit
that referenced
this pull request
Aug 11, 2023
* fixes stream signing * run code re-generation
amit-schreiber-firebolt
pushed a commit
to firebolt-analytics/aws-sdk-cpp
that referenced
this pull request
May 8, 2025
* fixes stream signing * run code re-generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
There was a typo in code gen that effected how constructors were created and omitted the stream signer in cases when it was needed. This fixes that and the stream signer will be used again.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.