Skip to content

fixes document shape codegen.#2196

Merged
sbiscigl merged 1 commit intomainfrom
fix-document-shape-generation
Nov 14, 2022
Merged

fixes document shape codegen.#2196
sbiscigl merged 1 commit intomainfrom
fix-document-shape-generation

Conversation

@sbiscigl
Copy link
Copy Markdown
Collaborator

Description of changes:

There is an issue with codegen where if a list shape is a list of documents, the correct code is not generated.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review November 14, 2022 18:53
@sbiscigl sbiscigl merged commit 700efe3 into main Nov 14, 2022
@sbiscigl sbiscigl deleted the fix-document-shape-generation branch November 14, 2022 18:53
jmklix pushed a commit that referenced this pull request Aug 11, 2023
amit-schreiber-firebolt pushed a commit to firebolt-analytics/aws-sdk-cpp that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants