Code generation for Service BatchFunctions class #2683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
August 23, 2021 15:03
…Mapper method and helper methods
…batchFunctionsTypes and BatchManager
zoewangg
reviewed
Aug 26, 2021
...en/src/main/java/software/amazon/awssdk/codegen/model/config/customization/BatchManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/codegen/poet/batchmanager/BatchFunctionsClassSpec.java
Outdated
Show resolved
Hide resolved
codegen/src/main/java/software/amazon/awssdk/codegen/poet/batchmanager/BatchTypesUtils.java
Outdated
Show resolved
Hide resolved
codegen/src/main/java/software/amazon/awssdk/codegen/poet/batchmanager/BatchTypesUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/codegen/poet/batchmanager/BatchFunctionsClassSpec.java
Outdated
Show resolved
Hide resolved
...urces/software/amazon/awssdk/codegen/poet/batchmanager/test-batchmanager-batchfunctions.java
Outdated
Show resolved
Hide resolved
...urces/software/amazon/awssdk/codegen/poet/batchmanager/test-batchmanager-batchfunctions.java
Outdated
Show resolved
Hide resolved
...urces/software/amazon/awssdk/codegen/poet/batchmanager/test-batchmanager-batchfunctions.java
Outdated
Show resolved
Hide resolved
...c/main/java/software/amazon/awssdk/services/sqs/internal/batchmanager/SqsBatchFunctions.java
Show resolved
Hide resolved
...urces/software/amazon/awssdk/codegen/poet/batchmanager/test-batchmanager-batchfunctions.java
Outdated
Show resolved
Hide resolved
added 4 commits
August 26, 2021 13:31
… to reflect codegeneration pacakage structure
16lim21
changed the title
Contributor
Author
|
There are only a few code smells. Most are TODOs and 2 are related to code duplication (just some really short strings that are reused but wouldn't make sense to make into a constant). |
zoewangg
reviewed
Aug 26, 2021
| } | ||
|
|
||
| private String methodNameFromMemberModel(String memberModelName) { | ||
| // Have to lowercase second char as well since MD5 methods/members have the D capitalized as well |
Contributor
There was a problem hiding this comment.
It seems this does not cover for the case where more than 2 characters are capitalized.
Can we use this method instead? https://github.com/aws/aws-sdk-java-v2/blob/master/codegen/src/main/java/software/amazon/awssdk/codegen/model/intermediate/MemberModel.java#L174
...urces/software/amazon/awssdk/codegen/poet/batchmanager/test-batchmanager-batchfunctions.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Aug 26, 2021
.../src/main/java/software/amazon/awssdk/codegen/poet/batchmanager/BatchFunctionsClassSpec.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
zoewangg
approved these changes
Aug 27, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Sep 7, 2023
…5c0d218d1 Pull request: release <- staging/edc1b242-cf39-400b-b82e-b485c0d218d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Service specific batch managers will rely on a
BatchFunctionsutility file that defines all the necessary work to map combine individual requests to batch requests, map batch responses back to individual responses, and to generatebatchKeysfrom a request. Of the files/classes related a service batch manager, this is the most complicated so I put the modifications in a separate PR from the other classes.Description
Added code generation for the BatchFunctions file. Code generation for the rest of the service batch manager classes will be done in a separate PR.
Testing
Added codegen tests to check the generated batchFunctions class matched expectations for it. Also had to modify the other codegen tests since the service-2.json file had to be modified to include some operations and classes (since I am no parsing the service-2.json file to extract the shapes).
Types of changes
Checklist
mvn installsucceedsLicense