Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Sep 29, 2023

Motivation and Context

This test was disabled earlier as sigv4a signer wasn't wired up properly.

Modifications

Uncomment the test.

Testing

the test passes

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@gosar gosar requested a review from a team as a code owner September 29, 2023 21:52
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 478 Code Smells

84.7% 84.7% Coverage
4.5% 4.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar enabled auto-merge (squash) October 2, 2023 14:06
@gosar gosar merged commit 7a32ede into feature/master/sra-identity-auth Oct 2, 2023
@gosar gosar deleted the gosar/sra-ia-S3PresignerTest-enable branch October 3, 2023 04:31
aws-sdk-java-automation pushed a commit that referenced this pull request Nov 20, 2025
…af3898db6

Pull request: release <- staging/c4e82efc-6786-41e8-be02-c67af3898db6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants