Skip to content

Uncomment disabled S3PresignerTest for sigv4a #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Uncomment disabled S3PresignerTest for sigv4a #4513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions services/s3/src/test/java/software/amazon/awssdk/services/s3/S3PresignerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,6 @@ public void accessPointArn_outpost_differentRegion_useArnRegionFalse_throwsIlleg
.hasMessageContaining("Invalid configuration: region from ARN `us-east-1` does not match client region `us-west-2` and UseArnRegion is `false`");
}

/*
@Test
// TODO(sra-identity-and-auth), this test fails with Expected :"AWS4-ECDSA-P256-SHA256", Actual :"AWS4-HMAC-SHA256"
public void accessPointArn_multiRegion_useArnRegionTrue_correctEndpointAndSigner() {
Expand All @@ -662,7 +661,6 @@ public void accessPointArn_multiRegion_useArnRegionTrue_correctEndpointAndSigner
.isEqualTo("AWS4-ECDSA-P256-SHA256");
assertThat(presignedRequest.url().toString()).startsWith(customEndpoint);
}
*/

@Test
public void outpostArn_usWest_calculatesCorrectSignature() {
Expand Down