Skip to content

Conversation

@cenedhryn
Copy link
Contributor

Motivation and Context

Client endpoint tests for S3 were not generated due to faulty codegen logic.

Modifications

Updated logic & changed it to be more readable

Testing

Ran on S3 module

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@cenedhryn cenedhryn requested a review from a team as a code owner November 1, 2023 18:53
@cenedhryn cenedhryn force-pushed the salande/fix-codegen-client-ep-tests branch from cf138a0 to d84b7f6 Compare November 1, 2023 23:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

32.4% 32.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dagnir
Copy link
Contributor

dagnir commented Nov 2, 2023

Does this fix the issue where we were still generating tests for test cases without operation input?

@cenedhryn
Copy link
Contributor Author

Does this fix the issue where we were still generating tests for test cases without operation input?

Yes

@cenedhryn cenedhryn merged commit 82d48cc into master Nov 2, 2023
@cenedhryn cenedhryn deleted the salande/fix-codegen-client-ep-tests branch May 13, 2024 00:52
aws-sdk-java-automation added a commit that referenced this pull request Jan 13, 2026
…6b43158fc

Pull request: release <- staging/368df409-ae4e-4e8d-b788-5606b43158fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants