Skip to content

Conversation

@Fred1155
Copy link
Contributor

@Fred1155 Fred1155 commented Nov 11, 2024

Motivation and Context

Add hasAWSQueryCompatible field to the marshaller, The SDKs will send an HTTP header x-amzn-query-mode set to true when a service has the @awsQueryCompatible trait.

Modifications

Add a boolean field hasAWSQueryCompatible to JsonProtocolMarshaller and its builder(default set as false) If it is true then add x-amzn-query-mode to the header of the http request

Testing

I added two testcases to validate SDK sends x-amzn-query-mode header when service has @awsQueryCompatible trait

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner November 11, 2024 21:34
@sonarqubecloud
Copy link

@Fred1155 Fred1155 requested a review from millems November 12, 2024 21:48
@Fred1155 Fred1155 enabled auto-merge November 12, 2024 21:48
@Fred1155
Copy link
Contributor Author

Thank you for the comments! Could you please review it again?

@Fred1155 Fred1155 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 3d71912 Nov 14, 2024
17 checks passed
@Fred1155 Fred1155 deleted the bole/add-query-mode-header branch November 14, 2024 01:02
@dagnir
Copy link
Contributor

dagnir commented Nov 22, 2024

@all-contributors please add @Fred1155 for code

@allcontributors
Copy link
Contributor

@dagnir

I've put up a pull request to add @Fred1155! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants