-
Notifications
You must be signed in to change notification settings - Fork 962
Add x-amzn-query-mode to http header when service has @awsQueryCompatible trait #5707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e6f07da
Added hasAWSQueryCompatible field to the marshaller to determine if a…
Fred1155 0ee8a10
Merge branch 'master' into bole/add-query-mode-header
Fred1155 2634caf
lines adjusted
Fred1155 87ce1e1
Merge branch 'master' into bole/add-query-mode-header
Fred1155 3ff5011
test case adjusted to also test BaseAwsJsonProtocolFactory
Fred1155 e5ce4d7
test case adjusted to also test BaseAwsJsonProtocolFactory
Fred1155 db2ade0
lines adjusted
Fred1155 48e72a9
Merge branch 'master' into bole/add-query-mode-header
Fred1155 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
...s-json-protocol/src/test/java/software/amazon/awssdk/protocols/json/AWSQueryModeTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.protocols.json; | ||
|
|
||
| import java.net.URI; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import org.junit.jupiter.api.Test; | ||
| import software.amazon.awssdk.core.ClientEndpointProvider; | ||
| import software.amazon.awssdk.core.SdkField; | ||
| import software.amazon.awssdk.core.SdkPojo; | ||
| import software.amazon.awssdk.core.client.config.SdkClientConfiguration; | ||
| import software.amazon.awssdk.core.client.config.SdkClientOption; | ||
| import software.amazon.awssdk.http.SdkHttpFullRequest; | ||
| import software.amazon.awssdk.http.SdkHttpMethod; | ||
| import software.amazon.awssdk.protocols.core.OperationInfo; | ||
| import software.amazon.awssdk.protocols.core.ProtocolMarshaller; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class AWSQueryModeTest { | ||
|
|
||
| private static final OperationInfo EMPTY_OPERATION_INFO = OperationInfo.builder() | ||
| .httpMethod(SdkHttpMethod.POST) | ||
| .hasImplicitPayloadMembers(true) | ||
| .build(); | ||
|
|
||
| /* | ||
| * A simple test POJO to marshall | ||
| */ | ||
| private static final class TestPojo implements SdkPojo { | ||
|
|
||
| private TestPojo() {} | ||
|
|
||
| @Override | ||
| public List<SdkField<?>> sdkFields() { | ||
| return Collections.emptyList(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equalsBySdkFields(Object other) { | ||
| if (!(other instanceof TestPojo)) { | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, SdkField<?>> sdkFieldNameToField() { | ||
| return Collections.emptyMap(); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| @Test | ||
| public void testMarshallWithAwsQueryCompatibleTrue() { | ||
| SdkClientConfiguration clientConfig = | ||
| SdkClientConfiguration.builder() | ||
| .option(SdkClientOption.CLIENT_ENDPOINT_PROVIDER, | ||
| ClientEndpointProvider.forEndpointOverride(URI.create("http://localhost"))) | ||
| .build(); | ||
| AwsJsonProtocolFactory factory = | ||
| AwsJsonProtocolFactory.builder() | ||
| .clientConfiguration(clientConfig) | ||
| .protocolVersion("1.1") | ||
| .protocol(AwsJsonProtocol.AWS_JSON) | ||
| .hasAwsQueryCompatible(true) | ||
| .build(); | ||
|
|
||
| ProtocolMarshaller<SdkHttpFullRequest> marshaller = factory.createProtocolMarshaller(EMPTY_OPERATION_INFO); | ||
| SdkPojo testPojo = new TestPojo(); | ||
|
|
||
| SdkHttpFullRequest result = marshaller.marshall(testPojo); | ||
|
|
||
| assertThat(result.headers()).containsKey("x-amzn-query-mode"); | ||
| assertThat(result.headers().get("x-amzn-query-mode").get(0)).isEqualTo("true"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMarshallWithNoAwsQueryCompatible() { | ||
| SdkClientConfiguration clientConfig = | ||
| SdkClientConfiguration.builder() | ||
| .option(SdkClientOption.CLIENT_ENDPOINT_PROVIDER, | ||
| ClientEndpointProvider.forEndpointOverride(URI.create("http://localhost"))) | ||
| .build(); | ||
| AwsJsonProtocolFactory factory = | ||
| AwsJsonProtocolFactory.builder() | ||
| .clientConfiguration(clientConfig) | ||
| .protocolVersion("1.1") | ||
| .protocol(AwsJsonProtocol.AWS_JSON) | ||
| .build(); | ||
|
|
||
| ProtocolMarshaller<SdkHttpFullRequest> marshaller = factory.createProtocolMarshaller(EMPTY_OPERATION_INFO); | ||
| SdkPojo testPojo = new TestPojo(); | ||
|
|
||
| SdkHttpFullRequest result = marshaller.marshall(testPojo); | ||
|
|
||
| assertThat(result.headers()).doesNotContainKey("x-amzn-query-mode"); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.