Don't special case 0 TTL in Apache 5 #6606
Merged
+215
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the definition of the CONNECTION_TIME_TO_LIVE (TTL) so that non-positive values indicate an infinite TTL. The reason for this is that in contrast to Apache 4.x, Apache 5.x uses 0 to indicate immediate expiry. This updated definition allows us to use a new default value of -1 across all supported HTTP clients to indicate an infinite TTL. Note that in practice, this is already the case, as all clients other than the Apache 5.x client treat non-positive values as infinite: - For Apache 4.x, value of <= 0 is treated as infinite: https://github.com/apache/httpcomponents-core/blob/a5c117028b7c620974304636d52f06f172f1d08b/httpcore/src/main/java/org/apache/http/pool/PoolEntry.java#L87-L93 - For Netty, `OldConnectionReaperHandler` is only used when the TTL value > 0, otherwise the handler is not added to the channel's pipeline: https://github.com/aws/aws-sdk-java-v2/blob/90f17ab300e27bee5367e4eff30b49bfa1f06af0/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/ChannelPipelineInitializer.java#L213-L216 - CRT and URLConnection client does not support this configuration.
dagnir
commented
Dec 2, 2025
| Duration connectionTtl = standardOptions.get(SdkHttpConfigurationOption.CONNECTION_TIME_TO_LIVE); | ||
| if (!connectionTtl.isZero()) { | ||
| // Skip TTL=0 to maintain backward compatibility (infinite in 4.x vs immediate expiration in 5.x) | ||
| if (!connectionTtl.isNegative()) { |
Contributor
Author
There was a problem hiding this comment.
Note: using isNegative() rather than isPositive() allows customer to have access to immediate expiry by directly setting Duration.ZERO. Should we allow this?
Shadow the global default CONNECTION_TIME_TO_LIVE value of 0 to -1 within the Apache 5 client instead of special casing the 0 value when building the connection config.
This reverts commit 86a120a.
dagnir
changed the title
dagnir
commented
Dec 3, 2025
...ents/apache5-client/src/main/java/software/amazon/awssdk/http/apache5/Apache5HttpClient.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ents/apache5-client/src/test/java/software/amazon/awssdk/http/apache5/ConnectionTtlTest.java
Show resolved
Hide resolved
dagnir
added
the
no-api-surface-area-change
|
zoewangg
approved these changes
Dec 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @zoewangg we don't want to update the default because it may affect external implementations of
SdkHttpClient/SdkAsyncHttpClient.Changing the default value locally to the Apache 5 client instead.No need for this any longer. Can simply ignore non-positive values.This commit updates the definition of the CONNECTION_TIME_TO_LIVE (TTL) so that non-positive values indicate an infinite TTL. The reason for this is that in contrast to Apache 4.x, Apache 5.x uses 0 to indicate immediate expiry. This updated definition allows us to use a new default value of -1 across all supported HTTP clients to indicate an infinite TTL.Note that in practice, this is already the case, as all clients other than the Apache 5.x client treat non-positive values as infinite:For Apache 4.x, value of <= 0 is treated as infinite: https://github.com/apache/httpcomponents-core/blob/a5c117028b7c620974304636d52f06f172f1d08b/httpcore/src/main/java/org/apache/http/pool/PoolEntry.java#L87-L93For Netty,
if (configuration.connectionTtlMillis() > 0) {
pipeline.addLast(new OldConnectionReaperHandler(configuration.connectionTtlMillis()));
}
OldConnectionReaperHandleris only used when the TTL value > 0, otherwise the handler is not added to the channel's pipeline:aws-sdk-java-v2/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/ChannelPipelineInitializer.java
Lines 213 to 216 in 90f17ab
CRT and URLConnection client does not support this configuration.Motivation and Context
Modifications
Testing
New unit tests to verify behavior.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License