Skip to content

Add CertificateRetriever impl#6794

Merged
dagnir merged 1 commit intofeature/master/sns-message-managerfrom
dongie/sns-cert-fetcher
Mar 16, 2026
Merged

Add CertificateRetriever impl#6794
dagnir merged 1 commit intofeature/master/sns-message-managerfrom
dongie/sns-cert-fetcher

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented Mar 13, 2026

Motivation and Context

CertificateRetriever is responsible for fetching the certificate, validating it, and caching it for future use.

Modifications

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

CertificateRetriever is responsible for fetching the certificate,
validating it, and caching it for future use.
@dagnir dagnir requested a review from a team as a code owner March 13, 2026 17:07
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
32.1% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dagnir dagnir merged commit c322b52 into feature/master/sns-message-manager Mar 16, 2026
33 of 41 checks passed
@dagnir dagnir deleted the dongie/sns-cert-fetcher branch March 16, 2026 20:31
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants