Conversation
|
davidh44
approved these changes
Apr 23, 2026
joviegas
approved these changes
Apr 23, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
The parameterized checksum tests in
MultipartClientChecksumTesthas hardcoded switch statement:multipartUpload_withChecksumValueProvided_shouldUseSameAlgorithmForUploadAndAddChecksumTypeFullObjectused aswitchoverChecksumAlgorithmto call the corresponding setter (e.g.,checksumCRC32(),checksumSHA256()). Every time a new checksum algorithm is added to the S3 model, this test would fail to compile until manually updated.Modifications
switchstatement with dynamicSdkField-based value setting. The test now finds the matching field via"Checksum" + algorithmonPutObjectRequest.Builder.sdkFields()and callsfield.set(), following the same pattern used inSdkPojoConversionUtils.multipartUpload_withMd5ChecksumValueProvided_shouldPassThrough— verifies that a pre-computed MD5 checksum value is forwarded through CreateMPU, UploadPart, and CompleteMPU requests withFULL_OBJECTchecksum type.multipartUpload_withMd5ChecksumAlgorithmProvided_shouldThrowException— verifies that settingchecksumAlgorithm(MD5)(asking the SDK to compute MD5) throws an exception with "MD5 is not supported".Testing
All
MultipartClientChecksumTesttests pass.Types of changes
Checklist
mvn clean install -pl :s3succeeds for affected modulesLicense