Add retry tests and onError cancel fix for presigned URL multipart downloads#6985
Merged
jencymaryjoseph merged 1 commit intoMay 20, 2026
Conversation
63db56f to
a4e1b31
Compare
Fred1155
approved these changes
May 20, 2026
12af83d
into
feature/master/pre-signed-url-getobject
5 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PR 6320 fixed a bug in
MultipartDownloaderSubscriberwhere in-flight GetObject futures were not cancelled whenonError()was invoked. The presigned URL serial subscriberPresignedUrlMultipartDownloaderSubscriberhad the same gap — when the publisher signalsonError, the active HTTP request continues running until timeout instead of being cancelled immediately.Also, added tests verifying retry behavior for presigned URL multipart downloads (retryable errors retry, non-retryable errors fail immediately).
Modifications
PresignedUrlMultipartDownloaderSubscriber.java— Track the current in-flight request and cancel it inonError()for immediate resource cleanup.Testing
New file:
PresignedUrlMultipartDownloaderSubscriberRetryWiremockTest.java— 9 parameterized tests × 2 transformer types (toBytes + toFile) = 18 runs covering non-retryable errors, retryable errors exhausting retries, IO errors, retry-then-succeed, and URL expiry during retry.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License