Skip to content

Add retry tests and onError cancel fix for presigned URL multipart downloads#6985

Merged
jencymaryjoseph merged 1 commit into
feature/master/pre-signed-url-getobjectfrom
jencyjos/pre-signed-url-getobject/retry-onerror-fix
May 20, 2026
Merged

Add retry tests and onError cancel fix for presigned URL multipart downloads#6985
jencymaryjoseph merged 1 commit into
feature/master/pre-signed-url-getobjectfrom
jencyjos/pre-signed-url-getobject/retry-onerror-fix

Conversation

@jencymaryjoseph
Copy link
Copy Markdown
Contributor

@jencymaryjoseph jencymaryjoseph commented May 20, 2026

Motivation and Context

  1. PR 6320 fixed a bug in MultipartDownloaderSubscriber where in-flight GetObject futures were not cancelled when onError() was invoked. The presigned URL serial subscriber PresignedUrlMultipartDownloaderSubscriber had the same gap — when the publisher signals onError, the active HTTP request continues running until timeout instead of being cancelled immediately.

  2. Also, added tests verifying retry behavior for presigned URL multipart downloads (retryable errors retry, non-retryable errors fail immediately).

Modifications

PresignedUrlMultipartDownloaderSubscriber.java — Track the current in-flight request and cancel it in onError() for immediate resource cleanup.

Testing

New file: PresignedUrlMultipartDownloaderSubscriberRetryWiremockTest.java — 9 parameterized tests × 2 transformer types (toBytes + toFile) = 18 runs covering non-retryable errors, retryable errors exhausting retries, IO errors, retry-then-succeed, and URL expiry during retry.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@jencymaryjoseph jencymaryjoseph requested a review from a team as a code owner May 20, 2026 19:56
@jencymaryjoseph jencymaryjoseph force-pushed the jencyjos/pre-signed-url-getobject/retry-onerror-fix branch from 63db56f to a4e1b31 Compare May 20, 2026 20:32
@jencymaryjoseph jencymaryjoseph merged commit 12af83d into feature/master/pre-signed-url-getobject May 20, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants