Skip auth scheme and endpoint resolution if already resolved by old interceptors#7012
Merged
S-Saranya1 merged 5 commits intoJun 3, 2026
Conversation
zoewangg
reviewed
Jun 3, 2026
| // Skip resolution if auth scheme was already resolved by an old service interceptor. | ||
| SelectedAuthScheme<?> existing = executionAttributes.getAttribute(SdkInternalExecutionAttribute.SELECTED_AUTH_SCHEME); | ||
| if (existing != null && !"unset".equals(existing.authSchemeOption().schemeId())) { | ||
| updateIdentityOnExistingScheme(existing, identityProviders, executionAttributes); |
Contributor
There was a problem hiding this comment.
Can we add some comments here explaining why we are doing this?
Contributor
Author
There was a problem hiding this comment.
Added the comments
| IdentityProviders identityProviders = updateIdentityProvidersIfNeeded(executionAttributes, sdkRequest); | ||
|
|
||
| // Skip resolution if auth scheme was already resolved by an old service interceptor. | ||
| SelectedAuthScheme<?> existing = executionAttributes.getAttribute(SdkInternalExecutionAttribute.SELECTED_AUTH_SCHEME); |
Contributor
Author
There was a problem hiding this comment.
Added tests for both auth and endpoint resolution
zoewangg
approved these changes
Jun 3, 2026
S-Saranya1
merged commit 437f380
into
feature/master/core-interceptors-migration
5 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When new core + old service, auth scheme and endpoint resolution would happen twice (once by old interceptors, once by pipeline stages). This adds unnecessary overhead, updating it to only resolve once.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License