Part [2/2] -Refactor Enhanced Client to use createX methods instead of builder#7073
Merged
RanVaknin merged 1 commit intoJun 26, 2026
Conversation
…e thew createX factory methods
zoewangg
approved these changes
Jun 25, 2026
RanVaknin
merged commit dc5918a
into
feature/master/DDB-enhanced-fast-AV-construction-optimization
3 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
RanVaknin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #7039
The previous PR did most of the work:
Introduced a new customization config flag that conditionally generates an alternative "direct" codepath for unions - specifically DDB's AttributeValue to avoid using the builder pattern, and instead use a factory methods which uses less memory allocations.
This PR wires those factories into the Enhanced Client's write paths. It replaces
AttributeValue.builder().x(v).build()withAttributeValue.createX(v)across all attribute converters, theEnhancedAttributeValuevisitor, andStaticImmutableTableSchema.