middleware-host-header sends an empty ":authority", which is invalid

[isker]

Describe the bug
middleware-host-header sends an empty :authority header in the request on http2:

aws-sdk-js-v3/packages/middleware-host-header/src/index.ts

Line 27 in fece417

request.headers[":authority"] = "";

This is invalid as per RFC3986 and RFC7230 and well-behaving servers must reject such requests. See https://trac.nginx.org/nginx/ticket/1551 for details.

SDK version number
@aws-sdk/middleware-host-header@1.0.0-gamma.6

Is the issue in the browser/Node.js/ReactNative?
Tested on node, perhaps present elsewhere.

Details of the browser/Node.js/ReactNative version

λ node -v
v13.9.0

To Reproduce (observed behavior)
The context is that I am playing around with an http/2 nginx proxy to S3 with the client configured to use NodeHttp2Handler so that clients on the WAN sending extremely large numbers of small S3 GETs may be served more performantly:

new S3({
  requestHandler: new NodeHttp2Handler(),
});

I understand that's a niche and perhaps nonsensical usecase, but I think this ought to be reproducible with anything that can be configured to use NodeHttp2Handler.

Expected behavior
middleware-host-header should send well-formed HTTP/2 requests.

[ajredniwja]

@isker thanks for opening this issue, this happens when using http2 with S3 which doesn't support http2.

Closing this issue now, please reach out if you see similar errors for services that support http2.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.