Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jul 10, 2020

Issue #, if available:
Fixes: #1352

Description of changes:
Get maxAttempts from maxAttemptsProvider, as it returns default value as per #1341

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1362 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   79.00%   78.99%   -0.02%     
==========================================
  Files         287      287              
  Lines       11112    11106       -6     
  Branches     2350     2349       -1     
==========================================
- Hits         8779     8773       -6     
  Misses       2333     2333              
Impacted Files Coverage Δ
packages/middleware-retry/src/defaultStrategy.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b7b7d...1fbe25f. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Jul 10, 2020

Replaced by #1363

@trivikr trivikr closed this Jul 10, 2020
@trivikr trivikr deleted the fix-browser-bundling branch July 10, 2020 23:01
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundler tries to bundle @aws-sdk/shared-ini-file-loader for browsers

2 participants