Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jul 10, 2020

Issue #, if available:
Fixes: #1352

Description of changes:
move retry defaults to middleware-retry

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #1363 into master will increase coverage by 0.02%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   79.00%   79.02%   +0.02%     
==========================================
  Files         287      287              
  Lines       11112    11123      +11     
  Branches     2350     2350              
==========================================
+ Hits         8779     8790      +11     
  Misses       2333     2333              
Impacted Files Coverage Δ
packages/abort-controller/src/AbortController.ts 100.00% <ø> (ø)
packages/abort-controller/src/AbortSignal.ts 100.00% <ø> (ø)
...-provider-cognito-identity/src/IndexedDbStorage.ts 19.14% <0.00%> (ø)
...ges/eventstream-marshaller/src/HeaderMarshaller.ts 100.00% <ø> (ø)
.../eventstream-marshaller/src/TestVectors.fixture.ts 100.00% <ø> (ø)
...tream-serde-universal/src/getUnmarshalledStream.ts 80.76% <ø> (ø)
packages/hash-blob-browser/src/index.ts 100.00% <ø> (ø)
packages/middleware-header-default/src/index.ts 90.90% <ø> (ø)
packages/middleware-host-header/src/index.ts 80.00% <ø> (ø)
...ckages/middleware-location-constraint/src/index.ts 87.50% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47770fa...dc314d8. Read the comment docs.

@trivikr trivikr force-pushed the move-retry-defaults-to-middleware branch from 6e02d8c to dc314d8 Compare July 13, 2020 16:31
@trivikr trivikr merged commit cd6cba0 into aws:master Jul 13, 2020
@trivikr trivikr deleted the move-retry-defaults-to-middleware branch July 13, 2020 19:51
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundler tries to bundle @aws-sdk/shared-ini-file-loader for browsers

3 participants